chrome/browser/devtools/devtools_ui_bindings.cc - Issue 784513002: DevTools: speed up DevToolsUIBindings::DispatchProtocolMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 784513002: DevTools: speed up DevToolsUIBindings::DispatchProtocolMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index d7d6fa1374bd5ac6b025d4e7a8ade5f431058d12..a3dedcc899182599cb7ecf28ff279130b45fad99 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -449,9 +449,9 @@ void DevToolsUIBindings::DispatchProtocolMessage(

DCHECK(agent_host == agent_host_.get());

if (message.length() < kMaxMessageChunkSize) {

- base::StringValue message_value(message);

- CallClientFunction("DevToolsAPI.dispatchMessage",

- &message_value, NULL, NULL);

+ base::string16 javascript = base::UTF8ToUTF16(

+ "DevToolsAPI.dispatchMessage(" + message + ");");

yurys 2014/12/05 13:03:30 Content shell implementation should also be update

loislo 2014/12/05 13:11:26 Done.

+ web_contents_->GetMainFrame()->ExecuteJavaScript(javascript);

return;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »