Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 784493002: Encrypted Media: Rename NeedKey to EncryptedMediaInitData. (Closed)

Created:
6 years ago by xhwang
Modified:
6 years ago
Reviewers:
*jrummell, ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, lcwu+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, gunsch+watch_chromium.org, wjia+watch_chromium.org, ddorwin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Encrypted Media: Rename NeedKey to EncryptedMediaInitData. TBR=gunsch@chromium.org BUG=438110 Committed: https://crrev.com/e8c4181a33c4be92cc48c0386b3122a61fe96ec1 Cr-Commit-Position: refs/heads/master@{#307165}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -255 lines) Patch
M chromecast/media/cma/test/frame_segmenter_for_test.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M media/base/demuxer.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/demuxer_perftest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M media/base/stream_parser.h View 2 chunks +11 lines, -10 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 2 3 5 chunks +20 lines, -23 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 3 4 chunks +20 lines, -19 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 3 chunks +6 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 4 chunks +19 lines, -19 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 12 chunks +36 lines, -36 lines 0 comments Download
M media/filters/pipeline_integration_test_base.h View 2 chunks +6 lines, -5 lines 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.h View 2 chunks +10 lines, -9 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.h View 3 chunks +11 lines, -9 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 4 chunks +20 lines, -17 lines 0 comments Download
M media/formats/mpeg/mpeg_audio_stream_parser_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mpeg/mpeg_audio_stream_parser_base.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M media/formats/webm/webm_stream_parser.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/formats/webm/webm_stream_parser.cc View 4 chunks +15 lines, -14 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
xhwang
I thought EncryptedMediaInitData is clearer than EncryptionInitData. But it's also a little bit longer :( ...
6 years ago (2014-12-05 17:16:41 UTC) #3
xhwang
jrummell: PTAL
6 years ago (2014-12-05 20:17:48 UTC) #6
jrummell
lgtm w/nits. https://codereview.chromium.org/784493002/diff/40001/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://codereview.chromium.org/784493002/diff/40001/media/filters/chunk_demuxer_unittest.cc#newcode1163 media/filters/chunk_demuxer_unittest.cc:1163: void(const std::string& type, nit: Should this be ...
6 years ago (2014-12-06 01:08:07 UTC) #7
xhwang
comments addressed
6 years ago (2014-12-06 07:02:38 UTC) #8
xhwang
https://codereview.chromium.org/784493002/diff/40001/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://codereview.chromium.org/784493002/diff/40001/media/filters/chunk_demuxer_unittest.cc#newcode1163 media/filters/chunk_demuxer_unittest.cc:1163: void(const std::string& type, On 2014/12/06 01:08:06, jrummell wrote: > ...
6 years ago (2014-12-06 07:03:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784493002/60001
6 years ago (2014-12-06 07:04:20 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-06 08:10:10 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e8c4181a33c4be92cc48c0386b3122a61fe96ec1 Cr-Commit-Position: refs/heads/master@{#307165}
6 years ago (2014-12-06 08:10:56 UTC) #13
ddorwin
6 years ago (2014-12-11 02:06:44 UTC) #15
Message was sent while issue was closed. 
I forgot to send this comment.

https://codereview.chromium.org/784493002/diff/40001/media/blink/webmediaplay...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/784493002/diff/40001/media/blink/webmediaplay...
media/blink/webmediaplayer_impl.cc:715: // TODO(xhwang): Update this UMA name.
Maybe we should have two separate UMAs and deprecate the old one with prefixed.
Then we will have continuous data until prefixed is removed.

Powered by Google App Engine
This is Rietveld 408576698