Initial scroll-blocks-on compositor integration

Source/core/rendering/RenderBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 84 matching lines @@
 
 RenderBox::RenderBox(ContainerNode* node)
     : RenderBoxModelObject(node)
     , m_intrinsicContentLogicalHeight(-1)
     , m_minPreferredLogicalWidth(-1)
     , m_maxPreferredLogicalWidth(-1)
 {
     setIsBox();
 }
 
+LayerType RenderBox::layerTypeRequired() const
+{
+    // hasAutoZIndex only returns true if the element is positioned or a flex-item since
+    // position:static elements that are not flex-items get their z-index coerced to auto.
+    if (isPositioned() || createsGroup() || hasClipPath() || hasTransformRelatedProperty() || hasHiddenBackface() || hasReflection() || style()->specifiesColumns() || !style()->hasAutoZIndex() || style()->shouldCompositeForCurrentAnimations())

[skobes, 2015/01/07 18:49:24]

Could you wrap this line at some reasonable length?

[Rick Byers, 2015/01/08 21:08:11]

Done.

+        return NormalLayer;
+    if (style()->hasScrollBlocksOn()) {
+        if (isDocumentElement()) {

[Ian Vollick, 2015/01/06 04:13:51]

Once skobes' root layer scroll refactor is done, this could be accelerated,
right? See https://code.google.com/p/chromium/issues/detail?id=417782.

[skobes, 2015/01/07 18:49:24]

If I'm reading it right, this check is just making sure we don't create separate
RenderLayers for the document and the html element due to the special
propagation of scroll-blocks-on between the two?

[Rick Byers, 2015/01/08 21:08:11]

Right.  I've added a comment to clarify this.

+            ASSERT(style()->scrollBlocksOn() == view()->style()->scrollBlocksOn());
+            return NoLayer;
+        }
+        return NormalLayer;
+    }
+    if (hasOverflowClip())
+        return OverflowClipLayer;
+
+    return NoLayer;
+}
+
 void RenderBox::willBeRemovedFromTree()
 {
     if (m_rareData && m_rareData->m_spannerPlaceholder) {
         m_rareData->m_spannerPlaceholder->spannerWillBeRemoved();
         m_rareData->m_spannerPlaceholder = 0;
     }
     RenderBoxModelObject::willBeRemovedFromTree();
 }
 
 void RenderBox::willBeDestroyed()
@@ skipping 4404 matching lines @@
     computedValues.m_margins.m_end = marginEnd();
 
     setLogicalTop(oldLogicalTop);
     setLogicalWidth(oldLogicalWidth);
     setLogicalLeft(oldLogicalLeft);
     setMarginLeft(oldMarginLeft);
     setMarginRight(oldMarginRight);
 }
 
 } // namespace blink