LayoutTests/compositing/layer-creation/scroll-blocks-on-default.html - Issue 784453003: Initial scroll-blocks-on compositor integration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/layer-creation/scroll-blocks-on-default.html

Issue 784453003: Initial scroll-blocks-on compositor integration (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove unneeded TODO Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #layer {

	4 transform: translateZ(0);

	5 width: 20px;

	6 height: 20px;

	7 }

	8 </style>

	9 <script>

	10 if (window.testRunner) {

	11 window.testRunner.dumpAsText();

	12 }

	13

	14 onload = function() {

	15 var output = document.getElementById('output');

	16 if (window.internals)

	17 document.getElementById('output').innerText += window.internals.laye rTreeAsText(document, internals.LAYER_TREE_INCLUDES_SCROLL_BLOCKS_ON);
	Ian Vollick 2015/01/06 04:13:51 I think you want testRunner.setCustomTextOutput he I think you want testRunner.setCustomTextOutput here. See compositing/iframes/visibility-hidden-transformed-content.html Rick Byers 2015/01/08 21:08:11 Cool, thanks. The only downside is now the test d Show quoted text On 2015/01/06 04:13:51, vollick wrote: > I think you want testRunner.setCustomTextOutput here. See > compositing/iframes/visibility-hidden-transformed-content.html Cool, thanks. The only downside is now the test description (which describes what to expect in the output) is no longer visible in the output. But that's minor - it's fine if people need to look at the test file to validate a change in the output. Ian Vollick 2015/01/09 15:17:33 Yeah, if you do it like the test I agree, but you Show quoted text On 2015/01/08 21:08:11, Rick Byers wrote: > On 2015/01/06 04:13:51, vollick wrote: > > I think you want testRunner.setCustomTextOutput here. See > > compositing/iframes/visibility-hidden-transformed-content.html > > Cool, thanks. The only downside is now the test description (which describes > what to expect in the output) is no longer visible in the output. But that's > minor - it's fine if people need to look at the test file to validate a change > in the output. Yeah, if you do it like the test I agree, but you could prepend the description to the layer tree dump if you want it in the output.
	18 };

	19 </script>

	20 Verify we get the default scroll-blocks-on mode applied to the viewport, no addi tional layers created (even with an iframe), and no scroll-blocks-on mode applie d to any other layer.

	21 <div id="layer"></div>

	22 <iframe srcdoc="<div style='width: 15px;'></div>"></iframe>

	23 <pre id="output"></pre>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/compositing/layer-creation/scroll-blocks-on-default-expected.txt » ('j') | Source/core/css/resolver/StyleResolver.cpp » ('J')