Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 784433003: Revert of Don't check bucket permissions if --no-auth. (Closed)

Created:
6 years ago by Vadim Sh.
Modified:
6 years ago
Reviewers:
agable, iannucci, ojan
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org, ghost stip (do not use)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Revert of Don't check bucket permissions if --no-auth. (patchset #1 id:1 of https://codereview.chromium.org/772203002/) Reason for revert: Seems to break download_from_google_storage.py in gclient runhooks: Traceback (most recent call last): File "/b/depot_tools/download_from_google_storage.py", line 469, in <module> sys.exit(main(sys.argv)) File "/b/depot_tools/download_from_google_storage.py", line 458, in main code = check_bucket_permissions(base_url, gsutil, options.no_auth) TypeError: check_bucket_permissions() takes exactly 2 arguments (3 given) Original issue's description: > Don't check bucket permissions if --no-auth. > > Checking bucket permissions takes ~400ms. We don't > need to do this if --no-auth because we know we > won't get a 403 and the 404 check will be handled > later when we try to actually download the file. > > Also, remove the check for a null bucket. This > can't happen since we will throw a parser error > in the main function before we get to this code. > > R=iannucci@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293250 TBR=agable@chromium.org,iannucci@chromium.org,ojan@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M download_from_google_storage.py View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Vadim Sh.
Created Revert of Don't check bucket permissions if --no-auth.
6 years ago (2014-12-04 22:37:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784433003/1
6 years ago (2014-12-04 22:38:04 UTC) #2
Vadim Sh.
One example: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/39990/steps/update_scripts/logs/stdio I'm sure there are lot more...
6 years ago (2014-12-04 22:38:49 UTC) #3
agable
On 2014/12/04 at 22:38:49, vadimsh wrote: > One example: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/39990/steps/update_scripts/logs/stdio > > I'm sure there ...
6 years ago (2014-12-04 22:39:04 UTC) #4
commit-bot: I haz the power
Presubmit check for 784433003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-04 22:39:45 UTC) #6
agable
On 2014/12/04 at 22:39:04, agable wrote: > On 2014/12/04 at 22:38:49, vadimsh wrote: > > ...
6 years ago (2014-12-04 22:40:19 UTC) #7
Vadim Sh.
Ojan landed the fix instead.
6 years ago (2014-12-04 22:45:42 UTC) #8
ojan
6 years ago (2014-12-04 22:46:01 UTC) #9
Fixed in https://codereview.chromium.org/780113003.

Sorry for breaking the world. :(

Powered by Google App Engine
This is Rietveld 408576698