New Tab: fix tab title flickering.

chrome/browser/ui/search/search_tab_helper_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/search_tab_helper.h"
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/signin/fake_signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/search/search_ipc_router.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/ntp_logging_events.h"
 #include "chrome/common/omnibox_focus_state.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/mock_render_process_host.h"
+#include "grit/generated_resources.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_test_sink.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 
 namespace {
 
 class MockSearchIPCRouterDelegate : public SearchIPCRouter::Delegate {
  public:
   virtual ~MockSearchIPCRouterDelegate() {}
 
   MOCK_METHOD1(OnInstantSupportDetermined, void(bool supports_instant));
   MOCK_METHOD1(OnSetVoiceSearchSupport, void(bool supports_voice_search));
@@ skipping 160 matching lines @@
 
   const IPC::Message* message = process()->sink().GetUniqueMessageMatching(
       ChromeViewMsg_ChromeIdentityCheckResult::ID);
   ASSERT_TRUE(message != NULL);
 
   ChromeViewMsg_ChromeIdentityCheckResult::Param params;
   ChromeViewMsg_ChromeIdentityCheckResult::Read(message, &params);
   EXPECT_EQ(test_identity, params.a);
   ASSERT_FALSE(params.b);
 }
+
+class TabTitleObserver : public content::WebContentsObserver {
+ public:
+  explicit TabTitleObserver(content::WebContents* contents)
+      : WebContentsObserver(contents) {}
+
+  string16 title_on_start() { return title_on_start_; }
+  string16 title_on_commit() { return title_on_commit_; }
+
+ private:
+  virtual void DidStartProvisionalLoadForFrame(
+      int64 /* frame_id */,
+      int64 /* parent_frame_id */,
+      bool /* is_main_frame */,
+      const GURL& /* validated_url */,
+      bool /* is_error_page */,
+      bool /* is_iframe_srcdoc */,
+      content::RenderViewHost* /* render_view_host */) OVERRIDE {
+    title_on_start_ = web_contents()->GetTitle();
+  }
+
+  virtual void DidNavigateMainFrame(
+      const content::LoadCommittedDetails& /* details */,
+      const content::FrameNavigateParams& /* params */) OVERRIDE {
+    title_on_commit_ = web_contents()->GetTitle();
+  }
+
+  string16 title_on_start_;
+  string16 title_on_commit_;
+};
+
+TEST_F(SearchTabHelperTest, TitleIsSetForNTP) {
+  TabTitleObserver title_observer(web_contents());
+  NavigateAndCommit(GURL(chrome::kChromeUINewTabURL));
+  const string16 title = l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE);
+  EXPECT_EQ(title, title_observer.title_on_start());
+  EXPECT_EQ(title, title_observer.title_on_commit());
+  EXPECT_EQ(title, web_contents()->GetTitle());
+}