New Tab: fix tab title flickering.

chrome/browser/ui/search/search_tab_helper.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/search_tab_helper.h"
 
 #include <set>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
@@ skipping 203 matching lines @@
 
 void SearchTabHelper::ToggleVoiceSearch() {
   ipc_router_.ToggleVoiceSearch();
 }
 
 void SearchTabHelper::RenderViewCreated(
     content::RenderViewHost* render_view_host) {
   ipc_router_.SetPromoInformation(IsAppLauncherEnabled());
 }
 
+void SearchTabHelper::NavigateToPendingEntry(
+    const GURL& url,
+    content::NavigationController::ReloadType /* reload_type */) {
+  // Set the title on any pending entry corresponding to the NTP. This prevents
+  // any flickering of the tab title.
+  if (chrome::IsNTPURL(url, profile())) {

[Charlie Reis, 2013/11/22 23:19:12]

Is this just a sanity check, or is this called on every navigation?

(Even if we have to do it for every navigation, I agree that this is a better
spot than browser_navigator.cc.)

[samarth, 2013/11/25 15:32:13]

Called on every navigation.

+    content::NavigationEntry* entry =
+        web_contents_->GetController().GetVisibleEntry();
+    if (entry)
+      entry->SetTitle(l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE));
+  }
+}
+
 void SearchTabHelper::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
   if (IsCacheableNTP(web_contents_)) {
     if (details.http_status_code == 204 || details.http_status_code >= 400) {
       RedirectToLocalNTP();
       RecordCacheableNTPLoadHistogram(false);
       return;
     }
     RecordCacheableNTPLoadHistogram(true);
@@ skipping 313 matching lines @@
 void SearchTabHelper::RedirectToLocalNTP() {
   // Extra parentheses to declare a variable.
   content::NavigationController::LoadURLParams load_params(
       (GURL(chrome::kChromeSearchLocalNtpUrl)));
   load_params.referrer = content::Referrer();
   load_params.transition_type = content::PAGE_TRANSITION_SERVER_REDIRECT;
   // Don't push a history entry.
   load_params.should_replace_current_entry = true;
   web_contents_->GetController().LoadURLWithParams(load_params);
 }