Support persistent notifications in the PlatformNotificationServiceImpl.

chrome/browser/notifications/persistent_notification_delegate.cc

Index: chrome/browser/notifications/persistent_notification_delegate.cc
diff --git a/chrome/browser/notifications/persistent_notification_delegate.cc b/chrome/browser/notifications/persistent_notification_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..02e59a39942d049b1091e30764b9772b244f4efd
--- /dev/null
+++ b/chrome/browser/notifications/persistent_notification_delegate.cc
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/persistent_notification_delegate.h"
+
+#include "base/bind.h"
+#include "base/guid.h"
+#include "chrome/browser/notifications/platform_notification_service_impl.h"
+#include "content/public/common/persistent_notification_status.h"
+
+namespace {
+
+// Persistent notifications fired through the delegate do not care about the
+// lifetime of the Service Worker responsible for executing the event.
+void OnEventDispatchComplete(content::PersistentNotificationStatus status) {}
+
+}  // namespace
+
+PersistentNotificationDelegate::PersistentNotificationDelegate(
+    content::BrowserContext* browser_context,
+    int64 service_worker_registration_id,
+    const content::ShowDesktopNotificationHostMsgParams& params)
+    : browser_context_(browser_context),
+      service_worker_registration_id_(service_worker_registration_id),
+      notification_data_(params),
+      id_(base::GenerateGUID()) {}

[dewittj, 2014/12/11 17:18:50]

If I read this correctly, one of the use cases for persistent notification
delegates is to create them out of thin air based on information from the
Android notification center.  In that case, does it make sense to use a GUID for
the ID, since then a recreated notification will have a different ID than the
previous one.

It looks like we never use the ID over in service worker land:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

but with the TODO there using a random ID here seems a bit risky.

[Peter Beverloo, 2014/12/11 19:02:00]

I'm not sure whether it makes sense to re-create a
PersistentNotificationDelegate object from the NotificationUIManagerAndroid. My
current patch invokes PNSImpl::OnPersistentNotificationClick directly from the
NotifiationUIManagerAndroid. That also gives Android the ability to provide its
own DispatchComplete callback.

+
+PersistentNotificationDelegate::~PersistentNotificationDelegate() {}
+
+void PersistentNotificationDelegate::Display() {}
+
+void PersistentNotificationDelegate::Close(bool by_user) {}
+
+void PersistentNotificationDelegate::Click() {
+  PlatformNotificationServiceImpl::GetInstance()->OnPersistentNotificationClick(
+      browser_context_,
+      service_worker_registration_id_,
+      id_,
+      notification_data_,
+      base::Bind(&OnEventDispatchComplete));
+}
+
+std::string PersistentNotificationDelegate::id() const {
+  return id_;
+}