Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issue 784343002: [draft] flush visual state prototype (Closed)

Created:
6 years ago by mkosiba (inactive)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

flush visual state prototype BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -0 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 3 chunks +23 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 1 chunk +27 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 4 chunks +24 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mkosiba (inactive)
here is how I'd envision the hookup for the API to look like. https://codereview.chromium.org/240163005/ implements ...
6 years ago (2014-12-09 18:35:59 UTC) #2
mnaganov (inactive)
https://codereview.chromium.org/784343002/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/784343002/diff/1/content/browser/frame_host/render_frame_host_impl.cc#newcode179 content/browser/frame_host/render_frame_host_impl.cc:179: for(const auto& iter: flush_visual_state_callbacks_) { Considering the recent issue ...
6 years ago (2014-12-10 10:39:54 UTC) #4
mkosiba (inactive)
6 years ago (2014-12-10 15:25:53 UTC) #6
mkosiba (inactive)
6 years ago (2014-12-10 15:27:19 UTC) #8
Ignacio Solla
5 years, 11 months ago (2015-01-12 13:32:47 UTC) #9
Message was sent while issue was closed.
On 2014/12/10 15:27:19, mkosiba wrote:


Taking over this change here: https://codereview.chromium.org/831903004/

Powered by Google App Engine
This is Rietveld 408576698