Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 784323002: Pass --noharmony-scoping to tests validating that we throw on 'const' in strict mode. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Pass --noharmony-scoping to tests validating that we throw on 'const' in strict mode. R=marja@chromium.org BUG=v8:2198 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M test/mjsunit/strict-mode.js View 1 chunk +1 line, -1 line 0 comments Download
M test/preparser/strict-const.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/preparser/testcfg.py View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Lomov (no reviews)
PTAL
6 years ago (2014-12-09 17:14:50 UTC) #2
marja
lgtm
6 years ago (2014-12-09 17:18:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784323002/1
6 years ago (2014-12-09 17:22:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 08:55:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698