components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h - Issue 784253002: Measure network error rates with and without data reduction proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

Issue 784253002: Measure network error rates with and without data reduction proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_network_delegate.cc ('K') | « chrome/browser/net/chrome_network_delegate.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

index fbcbeb15a4695ed908ae5251f91fb98c3b975e6a..6e33b264729a22e2157cdae1854345610c296896 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

@@ -58,7 +58,10 @@ class DataReductionProxyUsageStats

// Callback intended to be called from |ChromeNetworkDelegate| when a

// request completes. This method is used to gather usage stats.

- void OnUrlRequestCompleted(const net::URLRequest* request, bool started);

+ // |is_main_frame| indicates whether or not this was a main frame resource

+ // load.

+ void OnUrlRequestCompleted(const net::URLRequest* request, bool started,

+ bool is_main_frame);

// Records the last bypass reason to |bypass_type_| and sets

// |triggering_request_| to true. A triggering request is the first request to