Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 784153006: [x86] Disable invalid checked load/store optimization. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[x86] Disable invalid checked load/store optimization. TEST=mjsunit/compiler/regress-lena R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/48a6766e780d5f5459f8480af2e284d27a956a53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -74 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +0 lines, -45 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
A test/mjsunit/compiler/regress-lena.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-09 14:10:51 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-09 14:12:26 UTC) #3
Benedikt Meurer
6 years ago (2014-12-09 14:16:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48a6766e780d5f5459f8480af2e284d27a956a53 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698