Improvements to commits page

Improvements to commits page

- Pre-load all commits on the server. This takes about 2 minutes.
- Add "load more" functionality to the commits page.
- Fix bug for the case when a branch head is not in the commits window.

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/c2e8e2cd9e5d7877ff784154ce2aeb3e72d5be69

[borenet, 2014-12-09 13:35:38]

borenet@google.com changed reviewers:
+ jcgregorio@google.com

[borenet, 2014-12-09 13:39:21]

Actually, put this on hold for a bit. There seems to be a bug in either
commit_cache or gitinfo which is causing commits to go missing.

[borenet, 2014-12-09 14:35:42]

Okay, I think this is fixed at patch set 2.

[jcgregorio, 2014-12-09 16:30:05]

https://codereview.chromium.org/784103004/diff/20001/monitoring/go/alertserve...
File monitoring/go/alertserver/main.go (right):

https://codereview.chromium.org/784103004/diff/20001/monitoring/go/alertserve...
monitoring/go/alertserver/main.go:191: if end, ok := q["end"]; ok {
This seems like a repeated pattern:

 if end, ok := q["end"]; ok {
			endInt, err := strconv.ParseInt(end[0], 10, 32)
			if err != nil {
				util.ReportError(w, r, err, fmt.Sprintf("Invalid value for parameter 'end'
(%s): %v", end, err))
				return
			}
			endIdx = int(endInt)
		}

Maybe break it out into a func?

https://codereview.chromium.org/784103004/diff/20001/monitoring/res/imp/commi...
File monitoring/res/imp/commits-sk.html (right):

https://codereview.chromium.org/784103004/diff/20001/monitoring/res/imp/commi...
monitoring/res/imp/commits-sk.html:462: console.error("Server returned invalid
data.");
Consider pumping errors like this into 'toast'.

  https://www.polymer-project.org/docs/elements/paper-elements.html#paper-toast

[borenet, 2014-12-09 20:17:12]

Uploaded patch set 3.

https://codereview.chromium.org/784103004/diff/20001/monitoring/go/alertserve...
File monitoring/go/alertserver/main.go (right):

https://codereview.chromium.org/784103004/diff/20001/monitoring/go/alertserve...
monitoring/go/alertserver/main.go:191: if end, ok := q["end"]; ok {
On 2014/12/09 16:30:05, jcgregorio wrote:
> This seems like a repeated pattern:
> 
>  if end, ok := q["end"]; ok {
> 			endInt, err := strconv.ParseInt(end[0], 10, 32)
> 			if err != nil {
> 				util.ReportError(w, r, err, fmt.Sprintf("Invalid value for parameter 'end'
> (%s): %v", end, err))
> 				return
> 			}
> 			endIdx = int(endInt)
> 		}
> 
> Maybe break it out into a func?

Done.

https://codereview.chromium.org/784103004/diff/20001/monitoring/res/imp/commi...
File monitoring/res/imp/commits-sk.html (right):

https://codereview.chromium.org/784103004/diff/20001/monitoring/res/imp/commi...
monitoring/res/imp/commits-sk.html:462: console.error("Server returned invalid
data.");
On 2014/12/09 16:30:05, jcgregorio wrote:
> Consider pumping errors like this into 'toast'.
> 
>  
https://www.polymer-project.org/docs/elements/paper-elements.html#paper-toast 

Yeah, I think that's a good idea in general. In this case it's client/server
communication that shouldn't go wrong once I've gotten it right.  I can add it
if you want, but I don't think it'll be terribly helpful.

[jcgregorio, 2014-12-09 20:21:06]

On 2014/12/09 at 20:17:12, borenet wrote:
> Uploaded patch set 3.
> 
>
https://codereview.chromium.org/784103004/diff/20001/monitoring/go/alertserve...
> File monitoring/go/alertserver/main.go (right):
> 
>
https://codereview.chromium.org/784103004/diff/20001/monitoring/go/alertserve...
> monitoring/go/alertserver/main.go:191: if end, ok := q["end"]; ok {
> On 2014/12/09 16:30:05, jcgregorio wrote:
> > This seems like a repeated pattern:
> > 
> >  if end, ok := q["end"]; ok {
> > 			endInt, err := strconv.ParseInt(end[0], 10, 32)
> > 			if err != nil {
> > 				util.ReportError(w, r, err, fmt.Sprintf("Invalid value for parameter
'end'
> > (%s): %v", end, err))
> > 				return
> > 			}
> > 			endIdx = int(endInt)
> > 		}
> > 
> > Maybe break it out into a func?
> 
> Done.
> 
>
https://codereview.chromium.org/784103004/diff/20001/monitoring/res/imp/commi...
> File monitoring/res/imp/commits-sk.html (right):
> 
>
https://codereview.chromium.org/784103004/diff/20001/monitoring/res/imp/commi...
> monitoring/res/imp/commits-sk.html:462: console.error("Server returned invalid
data.");
> On 2014/12/09 16:30:05, jcgregorio wrote:
> > Consider pumping errors like this into 'toast'.
> > 
> >  
https://www.polymer-project.org/docs/elements/paper-elements.html#paper-toast 
> 
> Yeah, I think that's a good idea in general. In this case it's client/server
communication that shouldn't go wrong once I've gotten it right.  I can add it
if you want, but I don't think it'll be terribly helpful.

Not going to be a stickler about it, but that does remind me, there should
probably be a prober for skiaalerts.com:

 
https://github.com/google/skia-buildbot/blob/master/compute_engine_scripts/mo...

[jcgregorio, 2014-12-09 20:21:57]

lgtm

[borenet, 2014-12-10 13:22:02]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-12-10 13:22:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/784103004/40001

[commit-bot: I haz the power, 2014-12-10 13:22:23]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/buildbot/+/c2e8e2cd9e5d7877ff784154ce2aeb3e72d5...