Issue 784053002: Cleanup GM:pictureshadertile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 784053002: Cleanup GM:pictureshadertile (Closed)

Created:
6 years ago by f(malita)

Modified:
6 years ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Cleanup GM:pictureshadertile Post review cleanup for https://codereview.chromium.org/733203005/ TBR=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/6cd1181bc1ccaa42acb6b54a48ffa39dcda47783

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -34 lines)			Patch
	M	gm/pictureshadertile.cpp	View		3 chunks	+34 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

f(malita)

https://codereview.chromium.org/733203005/diff/1/gm/pictureshadertile.cpp File gm/pictureshadertile.cpp (right): https://codereview.chromium.org/733203005/diff/1/gm/pictureshadertile.cpp#new... gm/pictureshadertile.cpp:61: protected: On 2014/12/08 20:01:31, robertphillips wrote: > rm these ...

6 years ago (2014-12-08 20:25:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784053002/1

6 years ago (2014-12-08 20:44:20 UTC) #3

commit-bot: I haz the power

6 years ago (2014-12-09 13:23:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6cd1181bc1ccaa42acb6b54a48ffa39dcda47783

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages