Issue 78403002: MIPS: Use SmiTst and TrySmiTag MacroAssembler instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78403002: MIPS: Use SmiTst and TrySmiTag MacroAssembler instructions. (Closed)

Created:
7 years, 1 month ago by kilvadyb

Modified:
7 years, 1 month ago

Reviewers:
kisg, Paul Lind, palfia, danno, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

MIPS: Use SmiTst and TrySmiTag MacroAssembler instructions. BUG=

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -26 lines)			Patch
M	src/mips/builtins-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Paul Lind

The code looks good. But there is a typo in the issue title: MacroAssembler. Please ...

7 years, 1 month ago (2013-11-20 17:46:02 UTC) #1

Committed as r17941.