Source/modules/push_messaging/PushController.h - Issue 783983003: Push API: move PushManager from Navigator to ServiceWorkerRegistration [switchover 6/6]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushController.h

Issue 783983003: Push API: move PushManager from Navigator to ServiceWorkerRegistration [switchover 6/6] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/push_messaging/PushController.h

diff --git a/Source/modules/push_messaging/PushController.h b/Source/modules/push_messaging/PushController.h

index 4930014ffd7a113bf0c75510139749c4a2d8f399..636898f6c4da28848b55e158f4b9c8aa2d710060 100644

--- a/Source/modules/push_messaging/PushController.h

+++ b/Source/modules/push_messaging/PushController.h

@@ -23,7 +23,7 @@ public:

static PassOwnPtrWillBeRawPtr<PushController> create(WebPushClient*);

static const char* supplementName();

static PushController* from(LocalFrame* frame) { return static_cast<PushController*>(WillBeHeapSupplement<LocalFrame>::from(frame, supplementName())); }

- static WebPushClient* clientFrom(LocalFrame*);

+ static WebPushClient& clientFrom(LocalFrame*);

virtual void trace(Visitor* visitor) override { WillBeHeapSupplement<LocalFrame>::trace(visitor); }

« no previous file with comments | « Source/modules/push_messaging/NavigatorPushManager.idl ('k') | Source/modules/push_messaging/PushController.cpp » ('j') | no next file with comments »