Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl - Issue 783983003: Push API: move PushManager from Navigator to ServiceWorkerRegistration [switchover 6/6]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/push_messaging/ServiceWorkerRegistrationPush.idl

Issue 783983003: Push API: move PushManager from Navigator to ServiceWorkerRegistration [switchover 6/6] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // http://www.w3.org/TR/push-api/#extensions-to-the-serviceworkerregistration-in terface

	6

	7 [

	8 RuntimeEnabled=PushMessaging,

	9 ] partial interface ServiceWorkerRegistration {

	10 // FIXME: this may be renamed depending on the result of https://github.com/ w3c/push-api/issues/47
	Peter Beverloo 2014/12/10 00:18:18 This FIXME feels a bit useless. If we rename it we This FIXME feels a bit useless. If we rename it we'll send a patch, if we don't... we don't have to send a patch. Not we have to send a patch for either outcome. Michael van Ouwerkerk 2014/12/10 15:13:06 You asked for a TODO here. Are you sure about this Show quoted text On 2014/12/10 00:18:18, Peter Beverloo wrote: > This FIXME feels a bit useless. If we rename it we'll send a patch, if we > don't... we don't have to send a patch. Not we have to send a patch for either > outcome. You asked for a TODO here. Are you sure about this? I'm not sure I understand what you're looking for here. Either way, it's trivial, but I'd prefer not to have such a comment as the consensus seems to be to use pushManager of type PushManager.
	11 readonly attribute PushManager pushManager;

	12 };

OLD	NEW

« Source/modules/push_messaging/PushManager.cpp ('K') | « Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp ('k') | no next file » | no next file with comments »