Removing HistoryService::profile() method

chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/incident_reporting/last_download_finder.h"
 
 #include <algorithm>
 #include <functional>
 #include <utility>
 
@@ skipping 321 matching lines @@
     case chrome::NOTIFICATION_PROFILE_DESTROYED:
       AbandonSearchInProfile(content::Source<Profile>(source).ptr());
       break;
     default:
       break;
   }
 }
 
 void LastDownloadFinder::OnHistoryServiceLoaded(
     HistoryService* history_service) {
-  OnProfileHistoryLoaded(history_service->profile(), history_service);
+  OnProfileHistoryLoaded(history_service->profile_, history_service);

[sdefresne, 2014/12/10 15:41:50]

Please do not access the instance variable profile_ either. Instead iterate over
profile_states_ and check if the HistoryService attached to the profile is the
same as the one passed to the event. Since the profile_states_ is checked into
OnProfileHistoryLoaded, I would inline the function there, something like this:

void LastDownloadFinder::OnHistoryServiceLoaded(
    HistoryService* history_service) {
  for (const auto& pair : profile_states_) {
    HistoryService* hs = HistoryServiceFactory::GetForProfileIfExists(
        pair.first, Profile::EXPLICIT_ACCESS);
    if (hs == history_service) {
      // Start the query in the history service if the finder was waiting for
the
      // service to load.
      if (pair.second == WAITING_FOR_HISTORY) {
        history_service->QueryDownloads(
            base::Bind(&LastDownloadFinder::OnDownloadQuery,
                       weak_ptr_factory_.GetWeakPtr(),
                       pair.first));
    }
    break;
  }
}

[Paritosh Kumar, 2014/12/11 11:49:54]

Thanks Updated as per suggestion.

 }
 
 void LastDownloadFinder::HistoryServiceBeingDeleted(
     HistoryService* history_service) {
   history_service_observer_.Remove(history_service);
 }
 
 }  // namespace safe_browsing