linux_aura: Double clicking the titlebar should toggle maximized.

linux_aura: Double clicking the titlebar should toggle maximized.

This needs to be handled manually on Linux aura builds.

BUG=317486
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236592

[sadrul, 2013-11-20 22:46:21]

Doing this in RootView feels a bit odd. Perhaps this should be done in a
pre-target EventHandler on the root-window in corewm/ (like we do for ash in
WorkspaceEventHandler)?

+ben@ for corewm related thoughts.

[Elliot Glaysher, 2013-11-21 00:44:57]

On 2013/11/20 22:46:21, sadrul wrote:
> Doing this in RootView feels a bit odd. Perhaps this should be done in a
> pre-target EventHandler on the root-window in corewm/ (like we do for ash in
> WorkspaceEventHandler)?
> 
> +ben@ for corewm related thoughts.

Moved into the current X11WindowEventFitler. PTAL.

[Ben Goodger (Google), 2013-11-21 02:44:23]

yeah this seems like a better approach

[sadrul, 2013-11-21 04:59:38]

lgtm

https://codereview.chromium.org/78393003/diff/80001/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/x11_window_event_filter.cc (right):

https://codereview.chromium.org/78393003/diff/80001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/x11_window_event_filter.cc:113:
root_window_host_->Maximize();
You should event->SetHandled() this.

https://codereview.chromium.org/78393003/diff/80001/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/x11_window_event_filter.h (right):

https://codereview.chromium.org/78393003/diff/80001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/x11_window_event_filter.h:35: explicit
X11WindowEventFilter(aura::RootWindow* root_window,
Remove explicit

[commit-bot: I haz the power, 2013-11-21 18:58:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/78393003/200001

[commit-bot: I haz the power, 2013-11-21 20:56:21]

Change committed as 236592