Issue 783893004: Adding the MojoShell apk in the default targets on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 783893004: Adding the MojoShell apk in the default targets on android (Closed)

Created:
6 years ago by qsr

Modified:
6 years ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Adding the MojoShell apk in the default targets on android R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fbbee735e0cff54507d49c5fe17518c256ac65eb

Patch Set 2 : Fix spurous java file #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	shell/BUILD.gn	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

https://codereview.chromium.org/783893004/diff/1/shell/BUILD.gn File shell/BUILD.gn (right): https://codereview.chromium.org/783893004/diff/1/shell/BUILD.gn#newcode249 shell/BUILD.gn:249: "android/apk/src/org/chromium/mojo_shell_apk/LauncherService.java", Did you mean that?

6 years ago (2014-12-08 16:03:35 UTC) #2

qsr

6 years ago (2014-12-08 16:05:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fbbee735e0cff54507d49c5fe17518c256ac65eb (presubmit successful).

Expand Messages | Collapse Messages

Issue 783893004: Adding the MojoShell apk in the default targets on android (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix spurous java file #

Messages