Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 783813004: Build content_shell for performance test (Closed)

Created:
6 years ago by Xianzhu
Modified:
6 years ago
Reviewers:
dsinclair, dtu, nduca, tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Build content_shell for performance test Some blink performance suites need content_shell. To enable the suites, add content_shell to dependency list of chromium_builder_perf. This will increase the build time for compiling several C++ files and linking content_shell, which should be a small addition to the current build time. BUG=426599 TBR=dtu Committed: https://crrev.com/80e0ecb4181d786815db04b21e76032ad932e5a2 Cr-Commit-Position: refs/heads/master@{#307538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xianzhu
6 years ago (2014-12-09 00:13:23 UTC) #2
dtu
looks good to me
6 years ago (2014-12-09 00:28:21 UTC) #3
Xianzhu
On 2014/12/09 00:28:21, dtu wrote: > looks good to me I suppose this is a ...
6 years ago (2014-12-09 19:00:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783813004/1
6 years ago (2014-12-09 19:02:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 20:33:20 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-09 20:34:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80e0ecb4181d786815db04b21e76032ad932e5a2
Cr-Commit-Position: refs/heads/master@{#307538}

Powered by Google App Engine
This is Rietveld 408576698