Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 78373002: Removed ClientRestrictingServerMixIn from the policy testserver. (Closed)

Created:
7 years, 1 month ago by Joao da Silva
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removed ClientRestrictingServerMixIn from the policy testserver. This mixin restricts connections to the server to clients on the same machine. This restriction made sense in the original testserver since it was used for running local tests only; the policy testserver however is useful to test Chrome OS images in VMs and physical devices, which have a different address then the server's. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236295

Patch Set 1 #

Patch Set 2 : remove mixin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/policy/test/policy_testserver.py View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
I'd prefer to remove the ClientRestrictingServerMixIn altogether. I remember something about isolating tests as the ...
7 years, 1 month ago (2013-11-20 13:08:43 UTC) #1
Joao da Silva
Ready for another look.
7 years, 1 month ago (2013-11-20 13:35:12 UTC) #2
Mattias Nissler (ping if slow)
LGTM after you update the commit message; please include a paragraph on why this is ...
7 years, 1 month ago (2013-11-20 14:06:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/78373002/10002
7 years, 1 month ago (2013-11-20 14:16:03 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 21:19:50 UTC) #5
Message was sent while issue was closed.
Change committed as 236295

Powered by Google App Engine
This is Rietveld 408576698