Log serious OpenGL errors in remote CoreAnimation

Log serious OpenGL errors in remote CoreAnimation

This adds more spam in release builds, but will be valuable in
diagnosing bugs.

BUG=435786
Committed: https://crrev.com/78f24e75baf945a2c696fbd1bc0469656b200f99
Cr-Commit-Position: refs/heads/master@{#307069}

[ccameron, 2014-12-05 19:06:34]

ccameron@chromium.org changed reviewers:
+ kbr@chromium.org

[ccameron, 2014-12-05 19:07:27]

Empirically, it appears that LOG(ERROR) from the GPU process appears in
about:gpu's logs -- I didn't trace through the full logic, so let me know if I
may be making an error here.

[Ken Russell (switch to Gerrit), 2014-12-05 19:19:17]

As far as I know, yes, these should be routed back to about:gpu. You could
verify this by forcing one error in this code with some invalid OpenGL call
(passing an invalid enum to some harmless function, maybe) and making sure it
shows up. LGTM

[ccameron, 2014-12-05 19:38:18]

On 2014/12/05 19:19:17, Ken Russell wrote:
> As far as I know, yes, these should be routed back to about:gpu. You could
> verify this by forcing one error in this code with some invalid OpenGL call
> (passing an invalid enum to some harmless function, maybe) and making sure it
> shows up. LGTM

Thanks -- I tried logging at every swap, and I did see output, but not one per
frame (which was odd). As long as we should expect it, sounds good.

[ccameron, 2014-12-05 19:38:25]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-12-05 19:39:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/783713002/1

[commit-bot: I haz the power, 2014-12-05 20:23:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-05 20:23:48]

Patchset 1 (id:??) landed as
https://crrev.com/78f24e75baf945a2c696fbd1bc0469656b200f99
Cr-Commit-Position: refs/heads/master@{#307069}