Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 783683004: Remove virtual clear in PdfViewer's SkNulCanvas (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove virtual clear in PdfViewer's SkNulCanvas Causing compilation complaints on Windows Committed: https://skia.googlesource.com/skia/+/266b2adce7f99cd16c877d3ecff5108c58bb45d0

Patch Set 1 #

Patch Set 2 : Remove virtual clear in PdfViewer's SkNulCanvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years ago (2014-12-08 19:04:01 UTC) #2
reed1
lgtm
6 years ago (2014-12-08 19:27:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783683004/20001
6 years ago (2014-12-08 19:28:21 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-08 19:37:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/266b2adce7f99cd16c877d3ecff5108c58bb45d0

Powered by Google App Engine
This is Rietveld 408576698