Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 783673002: Fix %GetWeakSetValues to work correctly with GC. (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
CC:
v8-dev, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix %GetWeakSetValues to work correctly with GC. This fixes mjsunit/es6/mirror-collections failure in arm64 gc-stress bot. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/runtime/runtime-collections.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
PTAL
6 years ago (2014-12-05 12:45:36 UTC) #2
Yang
lgtm.
6 years ago (2014-12-05 13:01:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783673002/1
6 years ago (2014-12-05 13:02:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 13:26:59 UTC) #6
Dmitry Lomov (no reviews)
6 years ago (2014-12-05 13:28:50 UTC) #8
Message was sent while issue was closed. 
Adam, FYI

Powered by Google App Engine
This is Rietveld 408576698