Special check on Supervised User creation flow added to prevent misleading shelf alignment.

Special check on Supervised User creation flow added to prevent misleading shelf alignment.

BUG=405361
Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee
Cr-Commit-Position: refs/heads/master@{#309555}

[merkulova, 2014-12-05 13:49:54]

merkulova@chromium.org changed reviewers:
+ dzhioev@chromium.org

[dzhioev (left Google), 2014-12-08 15:51:49]

https://codereview.chromium.org/783663003/diff/1/ash/shelf/shelf_layout_manag...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/783663003/diff/1/ash/shelf/shelf_layout_manag...
ash/shelf/shelf_layout_manager.cc:261: if
(Shell::GetInstance()->session_state_delegate()->IsScreenLocked()) {
Since we don't support vertical alignment on all web ui screens (OOBE, lock,
user-adding), I believe the correct fix of the issue is to change
IsScreenLocked() to IsUserSessionBlocked() here and in
ShelfLayoutManager::GetAlignment(). As a bonus, you'll also fix the same problem
on user adding screen.
Current changes are not needed.

[merkulova, 2014-12-11 12:49:03]

https://codereview.chromium.org/783663003/diff/1/ash/shelf/shelf_layout_manag...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/783663003/diff/1/ash/shelf/shelf_layout_manag...
ash/shelf/shelf_layout_manager.cc:261: if
(Shell::GetInstance()->session_state_delegate()->IsScreenLocked()) {
On 2014/12/08 15:51:49, dzhioev wrote:
> Since we don't support vertical alignment on all web ui screens (OOBE, lock,
> user-adding), I believe the correct fix of the issue is to change
> IsScreenLocked() to IsUserSessionBlocked() here and in
> ShelfLayoutManager::GetAlignment(). As a bonus, you'll also fix the same
problem
> on user adding screen.
> Current changes are not needed.
 
They are necessary. As SU case is different: we don't cash state. Here  user
adding to multiprofile session is meant.

[merkulova, 2014-12-17 11:10:40]

merkulova@chromium.org changed reviewers:
+ skuhne@chromium.org

[merkulova, 2014-12-17 11:10:40]

PTAL

[dzhioev (left Google), 2014-12-18 14:53:58]

On 2014/12/17 11:10:40, merkulova wrote:
> PTAL

LGTM

[Mr4D (OOO till 08-26), 2014-12-19 01:46:29]

lgtm

[merkulova, 2014-12-19 06:10:07]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-12-19 06:10:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/783663003/20001

[commit-bot: I haz the power, 2014-12-19 07:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 07:05:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[merkulova, 2014-12-23 11:53:19]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-12-23 11:54:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/783663003/40001

[commit-bot: I haz the power, 2014-12-23 12:39:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-23 12:40:24]

Patchset 3 (id:??) landed as
https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee
Cr-Commit-Position: refs/heads/master@{#309555}

[Albert Bodenhamer, 2015-01-06 21:09:18]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/830393004/ by abodenha@chromium.org.

The reason for reverting is: Appears to have caused bug 446212.