Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 783663002: Implement ServiceWorkerClient attributes [1/3] (Closed)

Created:
6 years ago by Kunihiko Sakamoto
Modified:
6 years ago
Reviewers:
tkent, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -3 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 2 3 chunks +30 lines, -1 line 0 comments Download
M public/platform/WebServiceWorkerClientsInfo.h View 1 2 1 chunk +16 lines, -2 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Kunihiko Sakamoto
PTAL
6 years ago (2014-12-08 01:57:48 UTC) #2
nhiroki
LGTM https://codereview.chromium.org/783663002/diff/1/Source/modules/serviceworkers/ServiceWorkerContainer.cpp File Source/modules/serviceworkers/ServiceWorkerContainer.cpp (right): https://codereview.chromium.org/783663002/diff/1/Source/modules/serviceworkers/ServiceWorkerContainer.cpp#newcode288 Source/modules/serviceworkers/ServiceWorkerContainer.cpp:288: if (!context || !context->isDocument()) According to the ongoing ...
6 years ago (2014-12-08 04:07:06 UTC) #3
Kunihiko Sakamoto
Kent-san, could you take a look for public/platform? Thanks! https://codereview.chromium.org/783663002/diff/1/Source/modules/serviceworkers/ServiceWorkerContainer.cpp File Source/modules/serviceworkers/ServiceWorkerContainer.cpp (right): https://codereview.chromium.org/783663002/diff/1/Source/modules/serviceworkers/ServiceWorkerContainer.cpp#newcode288 Source/modules/serviceworkers/ServiceWorkerContainer.cpp:288: ...
6 years ago (2014-12-08 04:45:32 UTC) #5
tkent
https://codereview.chromium.org/783663002/diff/20001/public/platform/WebServiceWorkerClientsInfo.h File public/platform/WebServiceWorkerClientsInfo.h (right): https://codereview.chromium.org/783663002/diff/20001/public/platform/WebServiceWorkerClientsInfo.h#newcode9 public/platform/WebServiceWorkerClientsInfo.h:9: #include "WebURL.h" This should be "public/platform/WebURL.h" It's inconsistent with ...
6 years ago (2014-12-08 04:54:25 UTC) #6
Kunihiko Sakamoto
https://codereview.chromium.org/783663002/diff/20001/public/platform/WebServiceWorkerClientsInfo.h File public/platform/WebServiceWorkerClientsInfo.h (right): https://codereview.chromium.org/783663002/diff/20001/public/platform/WebServiceWorkerClientsInfo.h#newcode9 public/platform/WebServiceWorkerClientsInfo.h:9: #include "WebURL.h" On 2014/12/08 04:54:25, tkent wrote: > This ...
6 years ago (2014-12-08 05:12:04 UTC) #7
tkent
lgtm
6 years ago (2014-12-08 05:13:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783663002/40001
6 years ago (2014-12-08 05:17:56 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-08 06:24:53 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186665

Powered by Google App Engine
This is Rietveld 408576698