Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 783573003: Make TestPlugin allocate its bitmap with SharedBitmapManager (Closed)

Created:
6 years ago by jbauman
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make TestPlugin allocate its bitmap with SharedBitmapManager This paves the way for having TextureMailbox use SharedBitmaps instead of SharedMemory. Committed: https://crrev.com/2f5c1940866d185dab0ef9585d0dbcb7eb7eb618 Cr-Commit-Position: refs/heads/master@{#307150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M content/public/renderer/render_thread.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.cc View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbauman
6 years ago (2014-12-05 01:32:44 UTC) #2
pfeldman
You probably want someone more familiar with the code to take a look.
6 years ago (2014-12-05 10:56:27 UTC) #3
jbauman
6 years ago (2014-12-06 01:15:22 UTC) #5
piman
lgtm
6 years ago (2014-12-06 02:12:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783573003/1
6 years ago (2014-12-06 02:28:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-06 03:28:34 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-06 03:29:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f5c1940866d185dab0ef9585d0dbcb7eb7eb618
Cr-Commit-Position: refs/heads/master@{#307150}

Powered by Google App Engine
This is Rietveld 408576698