Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2576)

Unified Diff: chrome/installer/util/product.cc

Issue 783523004: Update installer to use the new version of LaunchProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/google_update_util.cc ('k') | chrome/installer/util/user_experiment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/product.cc
diff --git a/chrome/installer/util/product.cc b/chrome/installer/util/product.cc
index 96a42e34a4f1f2e9be9dee0834cac17dfc5317c9..d5dd118707bd28fb1294eed282b284ec464c9eb7 100644
--- a/chrome/installer/util/product.cc
+++ b/chrome/installer/util/product.cc
@@ -66,7 +66,7 @@ bool Product::LaunchChrome(const base::FilePath& application_path) const {
bool success = !application_path.empty();
if (success) {
CommandLine cmd(application_path.Append(installer::kChromeExe));
- success = base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
+ success = base::LaunchProcess(cmd, base::LaunchOptions()).IsValid();
}
return success;
}
« no previous file with comments | « chrome/installer/util/google_update_util.cc ('k') | chrome/installer/util/user_experiment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698