Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10471)

Unified Diff: chrome/installer/setup/setup_util_unittest.cc

Issue 783523004: Update installer to use the new version of LaunchProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_util.cc ('k') | chrome/installer/util/google_update_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_util_unittest.cc
diff --git a/chrome/installer/setup/setup_util_unittest.cc b/chrome/installer/setup/setup_util_unittest.cc
index 9b92429ca64b9125a5baf4b9acde2ecbe5ca5534..6c3430c295b68f444737cb72661dcfac18859d5c 100644
--- a/chrome/installer/setup/setup_util_unittest.cc
+++ b/chrome/installer/setup/setup_util_unittest.cc
@@ -229,12 +229,11 @@ ScopedPriorityClass::~ScopedPriorityClass() {
PriorityClassChangeResult RelaunchAndDoProcessPriorityAdjustment() {
CommandLine cmd_line(*CommandLine::ForCurrentProcess());
cmd_line.AppendSwitch(kAdjustProcessPriority);
- base::ProcessHandle process_handle = NULL;
+ base::Process process = base::LaunchProcess(cmd_line, base::LaunchOptions());
int exit_code = 0;
- if (!base::LaunchProcess(cmd_line, base::LaunchOptions(),
- &process_handle)) {
+ if (!process.IsValid()) {
ADD_FAILURE() << " to launch subprocess.";
- } else if (!base::WaitForExitCode(process_handle, &exit_code)) {
+ } else if (!process.WaitForExit(&exit_code)) {
ADD_FAILURE() << " to wait for subprocess to exit.";
} else {
return static_cast<PriorityClassChangeResult>(exit_code);
« no previous file with comments | « chrome/installer/setup/setup_util.cc ('k') | chrome/installer/util/google_update_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698