Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4309)

Unified Diff: chrome/installer/setup/setup_util.cc

Issue 783523004: Update installer to use the new version of LaunchProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/setup/setup_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_util.cc
diff --git a/chrome/installer/setup/setup_util.cc b/chrome/installer/setup/setup_util.cc
index 3e0a3d9dc61c0daa830a70c90f561ebb4978105b..f121fbf73756d159080fee8ac4b0d18eef9a66cc 100644
--- a/chrome/installer/setup/setup_util.cc
+++ b/chrome/installer/setup/setup_util.cc
@@ -70,13 +70,13 @@ bool LaunchAndWaitForExistingInstall(const base::FilePath& setup_exe,
// Launch the process and wait for it to exit.
VLOG(1) << "Launching existing installer with command: "
<< new_cl.GetCommandLineString();
- base::ProcessHandle handle = INVALID_HANDLE_VALUE;
- if (!base::LaunchProcess(new_cl, base::LaunchOptions(), &handle)) {
+ base::Process process = base::LaunchProcess(new_cl, base::LaunchOptions());
+ if (!process.IsValid()) {
PLOG(ERROR) << "Failed to launch existing installer with command: "
<< new_cl.GetCommandLineString();
return false;
}
- if (!base::WaitForExitCode(handle, exit_code)) {
+ if (!process.WaitForExit(exit_code)) {
PLOG(DFATAL) << "Failed to get exit code from existing installer";
*exit_code = WAIT_FOR_EXISTING_FAILED;
} else {
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/setup/setup_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698