Update installer to use the new version of LaunchProcess.

chrome/installer/util/user_experiment.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/user_experiment.h"
 
 #include <windows.h>
 #include <sddl.h>
 #include <wtsapi32.h>
 #include <vector>
@@ skipping 118 matching lines @@
     // to do so. That is the process that needs the key.
     std::string key(switches::kToastResultsKey);
     std::string toast_key = current_cmd_line.GetSwitchValueASCII(key);
     if (!toast_key.empty()) {
       cmd_line->AppendSwitchASCII(key, toast_key);
 
       // Use handle inheritance to make sure the duplicated toast results key
       // gets inherited by the child process.
       base::LaunchOptions options;
       options.inherit_handles = true;
-      return base::LaunchProcess(*cmd_line, options, NULL);
+      base::Process process = base::LaunchProcess(*cmd_line, options);
+      return process.IsValid();
     }
   }
 
-  return base::LaunchProcess(*cmd_line, base::LaunchOptions(), NULL);
+  base::Process process = base::LaunchProcess(*cmd_line, base::LaunchOptions());
+  return process.IsValid();
 }
 
 // For System level installs, setup.exe lives in the system temp, which
 // is normally c:\windows\temp. In many cases files inside this folder
 // are not accessible for execution by regular user accounts.
 // This function changes the permissions so that any authenticated user
 // can launch |exe| later on. This function should only be called if the
 // code is running at the system level.
 bool FixDACLsForExecute(const base::FilePath& exe) {
   // The general strategy to is to add an ACE to the exe DACL the quick
@@ skipping 79 matching lines @@
                 << console_id;
     return false;
   }
   // Note: Handle inheritance must be true in order for the child process to be
   // able to use the duplicated handle above (Google Update results).
   base::LaunchOptions options;
   options.as_user = user_token;
   options.inherit_handles = true;
   options.empty_desktop_name = true;
   VLOG(1) << __FUNCTION__ << " launching " << cmd_line->GetCommandLineString();
-  bool launched = base::LaunchProcess(*cmd_line, options, NULL);
+  base::Process process = base::LaunchProcess(*cmd_line, options);
   ::CloseHandle(user_token);
-  VLOG(1) << __FUNCTION__ << "   result: " << launched;
-  return launched;
+  VLOG(1) << __FUNCTION__ << "   result: " << process.IsValid();
+  return process.IsValid();
 }
 
 // A helper function that writes to HKLM if the handle was passed through the
 // command line, but HKCU otherwise. |experiment_group| is the value to write
 // and |last_write| is used when writing to HKLM to determine whether to close
 // the handle when done.
 void SetClient(const base::string16& experiment_group, bool last_write) {
   static int reg_key_handle = -1;
   if (reg_key_handle == -1) {
     // If a specific Toast Results key handle (presumably to our HKLM key) was
@@ skipping 264 matching lines @@
   if (outcome != kToastExpUninstallGroup)
     return;
   // The user wants to uninstall. This is a best effort operation. Note that
   // we waited for chrome to exit so the uninstall would not detect chrome
   // running.
   bool system_level_toast = CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kSystemLevelToast);
 
   CommandLine cmd(InstallUtil::GetChromeUninstallCmd(
                       system_level_toast, product.distribution()->GetType()));
-  base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
+  base::LaunchProcess(cmd, base::LaunchOptions());
 }
 
 }  // namespace installer