Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 783493002: Change clear() to respect the clip (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Change clear() to respect the clip This reverts commit af641a1c10f176cb9617026d3cc93c117a85d13d. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -199 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +0 lines, -5 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +5 lines, -17 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkRecordDraw.h View 2 chunks +2 lines, -27 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkRecords.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 5 chunks +3 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +10 lines, -9 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/RecordDrawTest.cpp View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783493002/1
6 years ago (2014-12-04 14:20:38 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-04 14:20:39 UTC) #3
reed1
fix needed in chrome has landed
6 years ago (2014-12-04 15:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783493002/1
6 years ago (2014-12-04 15:49:57 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-04 15:50:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8eddfb50c0c9e4bcba6384a2ce39852b5fb5becb

Powered by Google App Engine
This is Rietveld 408576698