Fix for DiskCacheBackendTest.SimpleCacheOpenBadFile spurious failures

Fix for DiskCacheBackendTest.SimpleCacheOpenBadFile spurious failures

The test sometimes fails on windows, because entry file is not yet
closed when the test tries to write into it.

Committed: https://crrev.com/ecc4506278da847c36b22bda0ae98feb4fbf4a15
Cr-Commit-Position: refs/heads/master@{#308085}

[Leonid Kaplan, 2014-12-04 13:02:16]

xeor@yandex-team.ru changed reviewers:
+ gavinp@chromium.org

[Leonid Kaplan, 2014-12-04 13:04:27]

Hi,

I have got some spurous failures for SimpleCacheOpenBadFile test, which seem to
be caused by racing during closing a cache entry. Please have look at the fix

[gavinp, 2014-12-05 14:56:29]

On 2014/12/04 13:04:27, Leonid Kaplan wrote:
> Hi,
> 
> I have got some spurous failures for SimpleCacheOpenBadFile test, which seem
to
> be caused by racing during closing a cache entry. Please have look at the fix

Thanks! Sorry for the delay, I've been out of the office. I'll go over this
later today.

[gavinp, 2014-12-12 01:33:01]

Good catch. My apologies for the review latency!

https://codereview.chromium.org/783473002/diff/1/net/disk_cache/backend_unitt...
File net/disk_cache/backend_unittest.cc (right):

https://codereview.chromium.org/783473002/diff/1/net/disk_cache/backend_unitt...
net/disk_cache/backend_unittest.cc:3286: // Entry is being closed on simple
cache worker pool
We try and keep comments in complete English sentences. I suggest:

  // The entry is being closed the Simple Cache worker pool.

[gavinp, 2014-12-12 01:34:41]

And oh yes: LGTM.

[Leonid Kaplan, 2014-12-12 14:09:59]

The CQ bit was checked by xeor@yandex-team.ru

[commit-bot: I haz the power, 2014-12-12 14:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/783473002/20001

[commit-bot: I haz the power, 2014-12-12 14:55:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-12 14:56:04]

Patchset 2 (id:??) landed as
https://crrev.com/ecc4506278da847c36b22bda0ae98feb4fbf4a15
Cr-Commit-Position: refs/heads/master@{#308085}