Issue 783453003: Explicitly track whether incremental marking was activated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 783453003: Explicitly track whether incremental marking was activated (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)

Modified:
6 years ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Explicitly track whether incremental marking was activated In the gc-tracer, we check whether we're marking to figure out which part of the mark compact we're in. If we aborted incremental marking for whatever reason, the check fails and we might later run into trouble BUG=none R=hpayer@chromium.org LOG=n

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -5 lines)			Patch
M	src/heap/gc-tracer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/heap.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap/heap.cc	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/heap/incremental-marking.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/heap/incremental-marking.cc	View	4 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783453003/1

6 years ago (2014-12-04 16:18:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages