Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: content/browser/fileapi/file_system_url_request_job_unittest.cc

Issue 78343004: Net: Standardize HttpByteRange printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/file_system_url_request_job_unittest.cc
diff --git a/content/browser/fileapi/file_system_url_request_job_unittest.cc b/content/browser/fileapi/file_system_url_request_job_unittest.cc
index f414332988eae285158359f76300b0efb03e7164..7edd26aa6562076b6e61d4b45b76a1bed3f2d17c 100644
--- a/content/browser/fileapi/file_system_url_request_job_unittest.cc
+++ b/content/browser/fileapi/file_system_url_request_job_unittest.cc
@@ -26,6 +26,7 @@
#include "net/base/net_errors.h"
#include "net/base/net_util.h"
#include "net/base/request_priority.h"
+#include "net/http/http_byte_range.h"
#include "net/http/http_request_headers.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
@@ -220,10 +221,10 @@ TEST_F(FileSystemURLRequestJobTest, FileTestFullSpecifiedRange) {
buffer.get() + last_byte_position + 1);
net::HttpRequestHeaders headers;
- headers.SetHeader(net::HttpRequestHeaders::kRange,
- base::StringPrintf(
- "bytes=%" PRIuS "-%" PRIuS,
- first_byte_position, last_byte_position));
+ headers.SetHeader(
+ net::HttpRequestHeaders::kRange,
+ net::HttpByteRange::Bounded(
+ first_byte_position, last_byte_position).GetHeaderValue());
TestRequestWithHeaders(CreateFileSystemURL("bigfile"), &headers);
ASSERT_FALSE(request_->is_pending());
@@ -243,9 +244,9 @@ TEST_F(FileSystemURLRequestJobTest, FileTestHalfSpecifiedRange) {
buffer.get() + buffer_size);
net::HttpRequestHeaders headers;
- headers.SetHeader(net::HttpRequestHeaders::kRange,
- base::StringPrintf("bytes=%" PRIuS "-",
- first_byte_position));
+ headers.SetHeader(
+ net::HttpRequestHeaders::kRange,
+ net::HttpByteRange::RightUnbounded(first_byte_position).GetHeaderValue());
TestRequestWithHeaders(CreateFileSystemURL("bigfile"), &headers);
ASSERT_FALSE(request_->is_pending());
EXPECT_EQ(1, delegate_->response_started_count());
@@ -269,7 +270,9 @@ TEST_F(FileSystemURLRequestJobTest, FileTestMultipleRangesNotSupported) {
TEST_F(FileSystemURLRequestJobTest, RangeOutOfBounds) {
WriteFile("file1.dat", kTestFileData, arraysize(kTestFileData) - 1);
net::HttpRequestHeaders headers;
- headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=500-1000");
+ headers.SetHeader(
+ net::HttpRequestHeaders::kRange,
+ net::HttpByteRange::Bounded(500, 1000).GetHeaderValue());
TestRequestWithHeaders(CreateFileSystemURL("file1.dat"), &headers);
ASSERT_FALSE(request_->is_pending());
« no previous file with comments | « content/browser/fileapi/blob_url_request_job_unittest.cc ('k') | content/browser/streams/stream_url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698