Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: content/browser/fileapi/blob_url_request_job_unittest.cc

Issue 78343004: Net: Standardize HttpByteRange printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/blob_url_request_job_unittest.cc
diff --git a/content/browser/fileapi/blob_url_request_job_unittest.cc b/content/browser/fileapi/blob_url_request_job_unittest.cc
index 93cacb240a10e5f513b87660f269e58fce79a84f..607bb10566bd0ef5a31ea108da8f5200de339832 100644
--- a/content/browser/fileapi/blob_url_request_job_unittest.cc
+++ b/content/browser/fileapi/blob_url_request_job_unittest.cc
@@ -13,6 +13,7 @@
#include "content/public/test/test_file_system_context.h"
#include "net/base/io_buffer.h"
#include "net/base/request_priority.h"
+#include "net/http/http_byte_range.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
#include "net/url_request/url_request.h"
@@ -397,7 +398,8 @@ TEST_F(BlobURLRequestJobTest, TestGetRangeRequest1) {
std::string result;
BuildComplicatedData(&result);
net::HttpRequestHeaders extra_headers;
- extra_headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=5-10");
+ extra_headers.SetHeader(net::HttpRequestHeaders::kRange,
+ net::HttpByteRange::Bounded(5, 10).GetHeaderValue());
expected_status_code_ = 206;
expected_response_ = result.substr(5, 10 - 5 + 1);
TestRequest("GET", extra_headers);
@@ -408,7 +410,8 @@ TEST_F(BlobURLRequestJobTest, TestGetRangeRequest2) {
std::string result;
BuildComplicatedData(&result);
net::HttpRequestHeaders extra_headers;
- extra_headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=-10");
+ extra_headers.SetHeader(net::HttpRequestHeaders::kRange,
+ net::HttpByteRange::Suffix(10).GetHeaderValue());
expected_status_code_ = 206;
expected_response_ = result.substr(result.length() - 10);
TestRequest("GET", extra_headers);

Powered by Google App Engine
This is Rietveld 408576698