Net: Standardize HttpByteRange printing

net/http/http_byte_range.h

Index: net/http/http_byte_range.h
diff --git a/net/http/http_byte_range.h b/net/http/http_byte_range.h
index 2c06434439d5c1589dfa00dde3607b832127e277..50d9e5b270eefab1d8d37cf66c7f45ff8d163898 100644
--- a/net/http/http_byte_range.h
+++ b/net/http/http_byte_range.h
@@ -5,6 +5,8 @@
 #ifndef NET_HTTP_HTTP_BYTE_RANGE_H_
 #define NET_HTTP_HTTP_BYTE_RANGE_H_
 
+#include <string>
+
 #include "base/basictypes.h"
 #include "net/base/net_export.h"
 
@@ -17,10 +19,16 @@ class NET_EXPORT HttpByteRange {
  public:
   HttpByteRange();
 
+  // Convenience constructors.
+  static HttpByteRange Bounded(int64 first_byte_position,
+                               int64 last_byte_position);
+  static HttpByteRange RightUnbounded(int64 first_byte_position);
+  static HttpByteRange Suffix(int64 suffix_length);
+
   // Since this class is POD, we use constructor, assignment operator
   // and destructor provided by compiler.
   int64 first_byte_position() const { return first_byte_position_; }
-  void set_first_byte_position(int64 value) { first_byte_position_ =  value; }
+  void set_first_byte_position(int64 value) { first_byte_position_ = value; }
 
   int64 last_byte_position() const { return last_byte_position_; }
   void set_last_byte_position(int64 value) { last_byte_position_ = value; }
@@ -38,6 +46,10 @@ class NET_EXPORT HttpByteRange {
   // Returns true if this range is valid.
   bool IsValid() const;
 
+  // Prints the range, e.g. "bytes=0-100", "bytes=100-", "bytes=-100".
+  // Assumes range is valid.
+  std::string PrintHeader() const;

[cbentzel, 2013/11/23 14:37:20]

I'd rather call this GetHeaderValue or GenerateHeader rather than PrintHeader()
since Print seems to indicate that the text will output somewhere (a printer,
console, or screen).

[tommycli, 2013/11/25 19:00:05]

Done.

+
   // A method that when given the size in bytes of a file, adjust the internal
   // |first_byte_position_| and |last_byte_position_| values according to the
   // range specified by this object. If the range specified is invalid with