Net: Standardize HttpByteRange printing

net/http/http_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_UTIL_H_
 #define NET_HTTP_HTTP_UTIL_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 48 matching lines @@
   // "Range" header is defined in RFC 2616 Section 14.35.1.
   // http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35.1
   static bool ParseRanges(const std::string& headers,
                           std::vector<HttpByteRange>* ranges);
 
   // Same thing as ParseRanges except the Range header is known and its value
   // is directly passed in, rather than requiring searching through a string.
   static bool ParseRangeHeader(const std::string& range_specifier,
                                std::vector<HttpByteRange>* ranges);
 
+  // Prints the ranges in the standard HTTP form, e.g. "bytes=0-10,300-400,-40".
+  // |ranges| must contain one or more elements. All elements must be valid.
+  static std::string PrintRanges(const std::vector<HttpByteRange>& ranges);
+
+  // Prints the range header a single range. Assumes a valid |range|.
+  static std::string PrintRange(const HttpByteRange& range);

[cbentzel, 2013/11/22 16:24:35]

Remove PrintRanges and place it in the only test file which uses it.

Move PrintRange over to HttpByteRange and remove this usage. No callers used
PrintInterval that I saw, and the byte units are really part of the header.

+
   // Scans the '\r\n'-delimited headers for the given header name.  Returns
   // true if a match is found.  Input is assumed to be well-formed.
   // TODO(darin): kill this
   static bool HasHeader(const std::string& headers, const char* name);
 
   // Returns true if it is safe to allow users and scripts to specify the header
   // named |name|.
   static bool IsSafeHeader(const std::string& name);
 
   // Strips all header lines from |headers| whose name matches
@@ skipping 271 matching lines @@
     // into the original's unquoted_value_ member.
     std::string unquoted_value_;
 
     bool value_is_quoted_;
   };
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_UTIL_H_