Source/modules/presentation/Presentation.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/presentation/Presentation.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/presentation/Presentation.cpp

diff --git a/Source/modules/presentation/Presentation.cpp b/Source/modules/presentation/Presentation.cpp

index 940811e62bcfc5e98cc090fd9ae5b4a545bc6540..88868c6f6633eba662fbfcc7a32589a704faa448 100644

--- a/Source/modules/presentation/Presentation.cpp

+++ b/Source/modules/presentation/Presentation.cpp

@@ -52,7 +52,7 @@ PresentationSession* Presentation::session() const

ScriptPromise Presentation::startSession(ScriptState* state, const String& senderId, const String& presentationId)

{

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

ScriptPromise promise = resolver->promise();

resolver->reject(DOMException::create(NotSupportedError, "The method is not supported yet."));

return promise;

@@ -60,7 +60,7 @@ ScriptPromise Presentation::startSession(ScriptState* state, const String& sende

ScriptPromise Presentation::joinSession(ScriptState* state, const String& senderId, const String& presentationId)

{

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

ScriptPromise promise = resolver->promise();

resolver->reject(DOMException::create(NotSupportedError, "The method is not supported yet."));

return promise;