Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: Source/modules/fetch/FetchManager.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/fetch/Body.cpp ('k') | Source/modules/geofencing/Geofencing.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/fetch/FetchManager.cpp
diff --git a/Source/modules/fetch/FetchManager.cpp b/Source/modules/fetch/FetchManager.cpp
index b031cde89803a52abe21a3de5ff6f495165d3553..c70822827a73d2004100f0c8038511ba4e6a7184 100644
--- a/Source/modules/fetch/FetchManager.cpp
+++ b/Source/modules/fetch/FetchManager.cpp
@@ -29,7 +29,7 @@ namespace blink {
class FetchManager::Loader : public ThreadableLoaderClient {
public:
- Loader(ExecutionContext*, FetchManager*, PassRefPtr<ScriptPromiseResolver>, const FetchRequestData*);
+ Loader(ExecutionContext*, FetchManager*, PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, const FetchRequestData*);
~Loader() override;
void didReceiveResponse(unsigned long, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
void didReceiveData(const char*, unsigned) override;
@@ -50,7 +50,7 @@ private:
ExecutionContext* m_executionContext;
FetchManager* m_fetchManager;
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
Persistent<FetchRequestData> m_request;
Persistent<BodyStreamBuffer> m_responseBuffer;
RefPtr<ThreadableLoader> m_loader;
@@ -59,7 +59,7 @@ private:
bool m_failed;
};
-FetchManager::Loader::Loader(ExecutionContext* executionContext, FetchManager* fetchManager, PassRefPtr<ScriptPromiseResolver> resolver, const FetchRequestData* request)
+FetchManager::Loader::Loader(ExecutionContext* executionContext, FetchManager* fetchManager, PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, const FetchRequestData* request)
: m_executionContext(executionContext)
, m_fetchManager(fetchManager)
, m_resolver(resolver)
@@ -359,7 +359,7 @@ FetchManager::~FetchManager()
ScriptPromise FetchManager::fetch(ScriptState* scriptState, const FetchRequestData* request)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
OwnPtr<Loader> ownLoader(adoptPtr(new Loader(m_executionContext, this, resolver.release(), request)));
« no previous file with comments | « Source/modules/fetch/Body.cpp ('k') | Source/modules/geofencing/Geofencing.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698