Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.h ('k') | Source/core/css/FontFaceSet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
diff --git a/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
index ad9c8271138e67d771a230a5d1e00a979ecb6d3b..13015e64874903739eb3b2f6fff148604131c4e8 100644
--- a/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
+++ b/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
@@ -75,12 +75,12 @@ TEST_F(ScriptPromiseResolverTest, construct)
{
ASSERT_FALSE(executionContext()->activeDOMObjectsAreStopped());
ScriptState::Scope scope(scriptState());
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState());
+ ScriptPromiseResolver::create(scriptState());
}
TEST_F(ScriptPromiseResolverTest, resolve)
{
- RefPtr<ScriptPromiseResolver> resolver;
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = nullptr;
ScriptPromise promise;
{
ScriptState::Scope scope(scriptState());
@@ -128,7 +128,7 @@ TEST_F(ScriptPromiseResolverTest, resolve)
TEST_F(ScriptPromiseResolverTest, reject)
{
- RefPtr<ScriptPromiseResolver> resolver;
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = nullptr;
ScriptPromise promise;
{
ScriptState::Scope scope(scriptState());
@@ -176,7 +176,7 @@ TEST_F(ScriptPromiseResolverTest, reject)
TEST_F(ScriptPromiseResolverTest, stop)
{
- RefPtr<ScriptPromiseResolver> resolver;
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = nullptr;
ScriptPromise promise;
{
ScriptState::Scope scope(scriptState());
@@ -204,6 +204,7 @@ TEST_F(ScriptPromiseResolverTest, stop)
EXPECT_EQ(String(), onRejected);
}
+#if !ENABLE(OILPAN)
TEST_F(ScriptPromiseResolverTest, keepAliveUntilResolved)
{
RefPtr<ScriptPromiseResolver> resolver;
@@ -266,10 +267,11 @@ TEST_F(ScriptPromiseResolverTest, suspend)
executionContext()->stopActiveDOMObjects();
EXPECT_EQ(1, resolver->refCount());
}
+#endif
TEST_F(ScriptPromiseResolverTest, resolveVoid)
{
- RefPtr<ScriptPromiseResolver> resolver;
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = nullptr;
ScriptPromise promise;
{
ScriptState::Scope scope(scriptState());
@@ -293,7 +295,7 @@ TEST_F(ScriptPromiseResolverTest, resolveVoid)
TEST_F(ScriptPromiseResolverTest, rejectVoid)
{
- RefPtr<ScriptPromiseResolver> resolver;
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = nullptr;
ScriptPromise promise;
{
ScriptState::Scope scope(scriptState());
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.h ('k') | Source/core/css/FontFaceSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698