Source/bindings/core/v8/CallbackPromiseAdapter.h - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html ('k') | Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/CallbackPromiseAdapter.h

diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h

index a6b525baeea61ec356aa440f89e917c0b6dff487..ce5eee8632dde1a288479e5fb18d0e4c32738bbc 100644

--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h

+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h

@@ -79,7 +79,7 @@ template<typename S, typename T>

class CallbackPromiseAdapter final : public blink::WebCallbacks<typename S::WebType, typename T::WebType> {

WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);

public:

- explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)

+ explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)

: m_resolver(resolver)

{

ASSERT(m_resolver);

@@ -105,14 +105,14 @@ public:

}

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

};

template<typename T>

class CallbackPromiseAdapter<void, T> final : public blink::WebCallbacks<void, typename T::WebType> {

WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);

public:

- explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)

+ explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)

: m_resolver(resolver)

{

ASSERT(m_resolver);

@@ -136,14 +136,14 @@ public:

}

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

};

template<typename T>

class CallbackPromiseAdapter<bool, T> final : public blink::WebCallbacks<bool, typename T::WebType> {

WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);

public:

- explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)

+ explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)

: m_resolver(resolver)

{

ASSERT(m_resolver);

@@ -167,14 +167,14 @@ public:

}

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

};

template<>

class CallbackPromiseAdapter<void, void> final : public blink::WebCallbacks<void, void> {

WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);

public:

- explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)

+ explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)

: m_resolver(resolver)

{

ASSERT(m_resolver);

@@ -196,14 +196,14 @@ public:

}

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

};

template<>

class CallbackPromiseAdapter<bool, void> final : public blink::WebCallbacks<bool, void> {

WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);

public:

- explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)

+ explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)

: m_resolver(resolver)

{

ASSERT(m_resolver);

@@ -225,7 +225,7 @@ public:

}

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

};

} // namespace blink