Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html
diff --git a/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html b/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html
index 6ab4bb750278a08e25315d23933c23ff59bee585..5dfa27189380f673755a39284e0bc68d3a4fa6d7 100644
--- a/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html
+++ b/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html
@@ -42,17 +42,30 @@
mediaKeys = result;
// Verify MediaKeys are not an ActiveDOMObject.
- assert_equals(numActiveDOMObjectsCreated(), 0, 'MediaKeys.create()');
+ // In non-Oilpan, numActiveDOMObjectsCreate() == 0.
+ // In Oilpan, numActiveDOMObjectsCreate() <= 2.
+ // (1 MediaKeysInitializer and
+ // 1 MediaKeySystemAccessInitializer).
+ assert_less_than_equal(numActiveDOMObjectsCreated(), 2, 'MediaKeys.create()');
var initDataType = getInitDataType();
var mediaKeySession = mediaKeys.createSession();
return mediaKeySession.generateRequest(initDataType, getInitData(initDataType));
}).then(function() {
// 1 MediaKeySession.
- assert_equals(numActiveDOMObjectsCreated(), 1, 'MediaKeys.createSession()');
+ // In non-Oilpan, numActiveDOMObjectsCreate() == 1.
+ // In Oilpan, numActiveDOMObjectsCreate() <= 4.
+ // (1 MediaKeysInitializer,
+ // 1 MediaKeySystemAccessInitializer,
+ // 1 ContentDecryptionModuleResultPromise and
+ // 1 MediaKeySession).
+ assert_less_than_equal(numActiveDOMObjectsCreated(), 4, 'MediaKeys.createSession(1)');
// Run gc(), should not affect MediaKeys object nor the
// session since we still have a reference to it.
+
+ // When enabling oilpan GC, the in-active
+ // ScriptPromiseResolvers will be destroyed.
return createGCPromise();
}).then(function(result) {
assert_equals(typeof mediaKeys.createSession, 'function');
« no previous file with comments | « no previous file | LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698