Source/modules/webaudio/AudioContext.h - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioContext.h

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | Source/modules/webaudio/AudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioContext.h

diff --git a/Source/modules/webaudio/AudioContext.h b/Source/modules/webaudio/AudioContext.h

index 14848d3dc68b2ac94767d5fcb5af8346cd5f88dc..a975f38345ea1995ba1ccbe9d8a77534bff98b10 100644

--- a/Source/modules/webaudio/AudioContext.h

+++ b/Source/modules/webaudio/AudioContext.h

@@ -317,9 +317,9 @@ private:

// Vector of promises created by resume(). It takes time to handle them, so we collect all of

// the promises here until they can be resolved or rejected.

- Vector<RefPtr<ScriptPromiseResolver> > m_resumeResolvers;

+ WillBeHeapVector<RefPtrWillBeMember<ScriptPromiseResolver> > m_resumeResolvers;

// Like m_resumeResolvers but for suspend().

- Vector<RefPtr<ScriptPromiseResolver> > m_suspendResolvers;

+ WillBeHeapVector<RefPtrWillBeMember<ScriptPromiseResolver> > m_suspendResolvers;

void rejectPendingResolvers();

// True if we're in the process of resolving promises for resume(). Resolving can take some