Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: Source/modules/serviceworkers/CacheStorage.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/CacheStorage.cpp
diff --git a/Source/modules/serviceworkers/CacheStorage.cpp b/Source/modules/serviceworkers/CacheStorage.cpp
index 1c5473a6ae80b78818ad31086697389bcc6f9413..9f6a6a859009d5b2bc70dbadfce91c0bcabfcb26 100644
--- a/Source/modules/serviceworkers/CacheStorage.cpp
+++ b/Source/modules/serviceworkers/CacheStorage.cpp
@@ -29,7 +29,7 @@ PassRefPtrWillBeRawPtr<DOMException> createNoImplementationException()
class CacheStorage::Callbacks final : public WebServiceWorkerCacheStorage::CacheStorageCallbacks {
WTF_MAKE_NONCOPYABLE(Callbacks);
public:
- explicit Callbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ explicit Callbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual ~Callbacks() { }
@@ -49,14 +49,14 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheStorage::WithCacheCallbacks final : public WebServiceWorkerCacheStorage::CacheStorageWithCacheCallbacks {
WTF_MAKE_NONCOPYABLE(WithCacheCallbacks);
public:
- WithCacheCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtr<ScriptPromiseResolver> resolver)
+ WithCacheCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_cacheName(cacheName), m_cacheStorage(cacheStorage), m_resolver(resolver) { }
virtual ~WithCacheCallbacks() { }
@@ -85,14 +85,14 @@ public:
private:
String m_cacheName;
Persistent<CacheStorage> m_cacheStorage;
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheStorage::MatchCallbacks : public WebServiceWorkerCacheStorage::CacheStorageMatchCallbacks {
WTF_MAKE_NONCOPYABLE(MatchCallbacks);
public:
- MatchCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ MatchCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual void onSuccess(WebServiceWorkerResponse* webResponse) override
@@ -111,7 +111,7 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
};
@@ -119,7 +119,7 @@ private:
class CacheStorage::DeleteCallbacks final : public WebServiceWorkerCacheStorage::CacheStorageCallbacks {
WTF_MAKE_NONCOPYABLE(DeleteCallbacks);
public:
- DeleteCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtr<ScriptPromiseResolver> resolver)
+ DeleteCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_cacheName(cacheName), m_cacheStorage(cacheStorage), m_resolver(resolver) { }
virtual ~DeleteCallbacks() { }
@@ -142,14 +142,14 @@ public:
private:
String m_cacheName;
Persistent<CacheStorage> m_cacheStorage;
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheStorage::KeysCallbacks final : public WebServiceWorkerCacheStorage::CacheStorageKeysCallbacks {
WTF_MAKE_NONCOPYABLE(KeysCallbacks);
public:
- explicit KeysCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ explicit KeysCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual ~KeysCallbacks() { }
@@ -169,7 +169,7 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
};
CacheStorage* CacheStorage::create(WebServiceWorkerCacheStorage* webCacheStorage)
@@ -179,7 +179,7 @@ CacheStorage* CacheStorage::create(WebServiceWorkerCacheStorage* webCacheStorage
ScriptPromise CacheStorage::open(ScriptState* scriptState, const String& cacheName)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_nameToCacheMap.contains(cacheName)) {
@@ -198,7 +198,7 @@ ScriptPromise CacheStorage::open(ScriptState* scriptState, const String& cacheNa
ScriptPromise CacheStorage::has(ScriptState* scriptState, const String& cacheName)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_nameToCacheMap.contains(cacheName)) {
@@ -216,7 +216,7 @@ ScriptPromise CacheStorage::has(ScriptState* scriptState, const String& cacheNam
ScriptPromise CacheStorage::deleteFunction(ScriptState* scriptState, const String& cacheName)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_webCacheStorage)
@@ -229,7 +229,7 @@ ScriptPromise CacheStorage::deleteFunction(ScriptState* scriptState, const Strin
ScriptPromise CacheStorage::keys(ScriptState* scriptState)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_webCacheStorage)
@@ -257,7 +257,7 @@ ScriptPromise CacheStorage::matchImpl(ScriptState* scriptState, const Request* r
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_webCacheStorage)

Powered by Google App Engine
This is Rietveld 408576698