Chromium Code Reviews

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/modules/webmidi/MIDIAccessInitializer.h
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h
index 0babda9d10b65dd7082a84c422b94a7b776d9679..6a26940101cb8511da0c1b92cc19ec0ab94b30c4 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.h
+++ b/Source/modules/webmidi/MIDIAccessInitializer.h
@@ -39,10 +39,10 @@ public:
static ScriptPromise start(ScriptState* scriptState, const MIDIOptions& options)
{
- RefPtr<MIDIAccessInitializer> p = adoptRef(new MIDIAccessInitializer(scriptState, options));
- p->keepAliveWhilePending();
- p->suspendIfNeeded();
- return p->start();
+ RefPtrWillBeRawPtr<MIDIAccessInitializer> resolver = adoptRefWillBeNoop(new MIDIAccessInitializer(scriptState, options));
sof 2014/12/16 21:34:59 Not directly overlapping with this change, but how
sof 2014/12/16 22:07:05 This block of code repeats in a number of create()
tasak 2014/12/17 08:40:08 I see. I will talk with yhirano@.
+ resolver->keepAliveWhilePending();
+ resolver->suspendIfNeeded();
+ return resolver->start();
}
virtual ~MIDIAccessInitializer();

Powered by Google App Engine