Source/modules/push_messaging/PushRegistrationCallbacks.h - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushRegistrationCallbacks.h

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/push_messaging/PushRegistration.cpp ('k') | Source/modules/push_messaging/PushRegistrationCallbacks.cpp » ('j') | Source/modules/webmidi/MIDIAccessInitializer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushRegistrationCallbacks.h

diff --git a/Source/modules/push_messaging/PushRegistrationCallbacks.h b/Source/modules/push_messaging/PushRegistrationCallbacks.h

index cdf4c90adbda1dd5c63bd080bda992acf4d1d8c2..7f93d27205d7e20b43a098da59f3e7200468fcde 100644

--- a/Source/modules/push_messaging/PushRegistrationCallbacks.h

+++ b/Source/modules/push_messaging/PushRegistrationCallbacks.h

@@ -25,14 +25,14 @@ struct WebPushRegistration;

class PushRegistrationCallbacks final : public WebCallbacks<WebPushRegistration, WebPushError> {

WTF_MAKE_NONCOPYABLE(PushRegistrationCallbacks);

public:

- PushRegistrationCallbacks(PassRefPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);

+ PushRegistrationCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);

~PushRegistrationCallbacks() override;

void onSuccess(WebPushRegistration*) override;

void onError(WebPushError*) override;

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

Persistent<ServiceWorkerRegistration> m_serviceWorkerRegistration;

};