Source/modules/geofencing/Geofencing.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geofencing/Geofencing.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp ('k') | Source/modules/navigatorconnect/NavigatorConnect.cpp » ('j') | Source/modules/webmidi/MIDIAccessInitializer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geofencing/Geofencing.cpp

diff --git a/Source/modules/geofencing/Geofencing.cpp b/Source/modules/geofencing/Geofencing.cpp

index ec2baeac84fabe4b179e806303f74344df91a9d1..d81709bc9aa0212f2c2d8c90612ccd57c7b12bc0 100644

--- a/Source/modules/geofencing/Geofencing.cpp

+++ b/Source/modules/geofencing/Geofencing.cpp

@@ -58,7 +58,7 @@ ScriptPromise Geofencing::registerRegion(ScriptState* scriptState, GeofencingReg

if (!provider)

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError));

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebGeofencingCallbacks* callbacks = new CallbackPromiseAdapter<void, GeofencingError>(resolver);

WebServiceWorkerRegistration* serviceWorkerRegistration = nullptr;

@@ -74,7 +74,7 @@ ScriptPromise Geofencing::unregisterRegion(ScriptState* scriptState, const Strin

if (!provider)

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError));

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebGeofencingCallbacks* callbacks = new CallbackPromiseAdapter<void, GeofencingError>(resolver);

WebServiceWorkerRegistration* serviceWorkerRegistration = nullptr;

@@ -90,7 +90,7 @@ ScriptPromise Geofencing::getRegisteredRegions(ScriptState* scriptState) const

if (!provider)

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError));

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebGeofencingRegionsCallbacks* callbacks = new CallbackPromiseAdapter<RegionArray, GeofencingError>(resolver);

WebServiceWorkerRegistration* serviceWorkerRegistration = nullptr;