Source/modules/webmidi/MIDIAccessInitializer.h - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webaudio/AudioContext.cpp ('K') | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/platform/exported/WebCryptoResult.cpp » ('j') | public/platform/WebCrypto.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webmidi/MIDIAccessInitializer.h

diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h

index 0babda9d10b65dd7082a84c422b94a7b776d9679..c8d3f6e8bff3f9652e9bc6a3d76f52a233b200fc 100644

--- a/Source/modules/webmidi/MIDIAccessInitializer.h

+++ b/Source/modules/webmidi/MIDIAccessInitializer.h

@@ -39,7 +39,7 @@ public:

static ScriptPromise start(ScriptState* scriptState, const MIDIOptions& options)

{

- RefPtr<MIDIAccessInitializer> p = adoptRef(new MIDIAccessInitializer(scriptState, options));

+ RefPtrWillBeRawPtr<MIDIAccessInitializer> p = adoptRefWillBeNoop(new MIDIAccessInitializer(scriptState, options));

haraken 2014/12/16 09:43:29 p => promise

tasak 2014/12/16 11:54:28 p => resolver

p->keepAliveWhilePending();

p->suspendIfNeeded();

return p->start();

« Source/modules/webaudio/AudioContext.cpp ('K') | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/platform/exported/WebCryptoResult.cpp » ('j') | public/platform/WebCrypto.h » ('J')